Generally speaking Xfce has very few unit tests – or tests at all – but since Jerome had laid a foundation for notification tests in xfce4-notifyd I decided to extend that to testing the icons in notifications. What inspired me to do so was that I noticed that notifyd was not in line with the fd.o notifications specification in two aspects:
- it didn’t support the “image-path” hint and
- the priorities of how to handle the icons were mixed up.
So my new “test-icons” test – which I wrote before(!) I implemented the fix for the priorities, even if I checked it into git only until later 😉 – checks whether the server handles all icon-related properties, hints and features and also checks whether the priority is in accordance with the specification. I also started some documentation on what parts of the freedesktop.org specification are implemented in xfce4-notifyd and which ones are not (prominent example which is not implemented: sound).
Other than that a thank-you goes to Olivier for contributing another build-fix. Finally I managed to get a few more bugs fixed, most notably a general theming issue (action buttons were sometimes mis-styled) and hiding notification buttons without label. Together with the translation updates I think this makes 0.3.3 a worthwhile release.
Final note: currently there are only 12 bugs open on the tracker, of which several are feature requests so things seem to be going quite well!